Skip to content

DM-5792: Support artifacts on all images that have them (currently wise and 2mass) #460

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 19, 2017
Merged

DM-5792: Support artifacts on all images that have them (currently wise and 2mass) #460

merged 2 commits into from
Sep 19, 2017

Conversation

robyww
Copy link
Contributor

@robyww robyww commented Sep 15, 2017

  • Image FileRetrievers can add artifact to RelatedData
  • WISE and 2MASS supported
  • Artifact drawing layer uses lazy loading
  • added layer title matching for visibility, color, and symbol changing
  • firefly: IbeQueryArtifact replaces ife: FinderChartQueryArtifact
  • Also added support for getting adding RelatedData artifacts in IbeFileRetrieve

The big concept:

  • When an image plot is request is sent to the server it not only returns the image data but also how to retrieve "related data".
  • Sometime this related data are image mask in other cases it is artifact data.
  • What related data is return is query specific. This way the client does not have to know the details of the project.
  • A RelatedData object can be turned into a server search request to retrieve it when the user request to see it.
  • There are so far 3 types of related data: mask, tabular (artifacts), and image (not yet implemented).
  • The mask related data was implemented months ago. This pull request implements the tabular related data.

to test:

  • bring up the firefly or irsa viewer, or finder chart, or time series.
  • when you have a wise or 2mass layer up you should see the artifact drawing layers on the dialog. They are off by default.
  • if you have more than one image such as several wise or several 2mass images. Checking and unchecking artifact turn all of them of the same type on and off.

@robyww robyww self-assigned this Sep 15, 2017
@robyww robyww requested review from ejoliet and cwang2016 September 15, 2017 21:09
@robyww
DM-5792: Support artifacts on all images that have them (wise and 2mass)
f2aba67 
  - Image FileRetrievers can now artifacts to RelatedData
  - WISE and 2MASS supported
  - Artifact drawing layer uses lazy loading
  - added layer title matching for visibility, color, and symbol changing
  - firefly: IbeQueryArtifact replaces ife: FinderChartQueryArtifact
  - Also added support for getting adding RelatedData artifacts IbeFileRetrieve
cwang2016
cwang2016 reviewed Sep 19, 2017
View reviewed changes
src/firefly/js/drawingLayers/Artifact.js Outdated
diff_spikes: {color: 'orange', symbol: DrawSymbol.DOT, size: 1},
halos : {color: 'yellow', symbol: DrawSymbol.SQUARE, size: 3},
ghost : {color: 'pink', symbol: DrawSymbol.DIAMOND, size: 3},
latents : {color: 'green', symbol: DrawSymbol.X, size: 3},
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggestion: green might be difficult for some viewer, how about 'cyan' or some color neither green nor red.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was just matching the color from the old UI. It is a good suggestion. I will change it.

@robyww robyww merged commit 369eeb4 into dev Sep 19, 2017
@robyww robyww deleted the dm-5792-artifacts branch September 25, 2017 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cwang2016 cwang2016 cwang2016 approved these changes

@ejoliet ejoliet Awaiting requested review from ejoliet

Assignees

@robyww robyww

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@robyww @cwang2016